LuciferYang commented on PR #55957: URL: https://github.com/apache/spark/pull/55957#issuecomment-4484987437
Could you add an AVG-side schema-parity test (analogue of the SUM "peel preserves schema" test) that compares df.select(avg(cast(x, dec(p', s)))).schema between rule-on and rule-off (via OPTIMIZER_EXCLUDED_RULES)? Parity holds by construction since Average.dataType uses bounded(p' + 4, s + 4) too, but a regression test would lock that in — useful if the outer-Cast target ever gets edited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
