Yicong-Huang commented on code in PR #55954:
URL: https://github.com/apache/spark/pull/55954#discussion_r3264541092


##########
python/benchmarks/asv.conf.json:
##########
@@ -12,10 +12,12 @@
     "results_dir": ".asv/results",
     "html_dir": ".asv/html",
     "build_command": [
-        "python -m pip wheel --no-deps -w {build_cache_dir} 
{conf_dir}/../packaging/classic"
+        "{build_dir}/build/sbt -batch -DskipTests clean package",

Review Comment:
   I think we can differentiate two modes:
   1. run with full spark/pyspark, which requires building spark (scala). 
   2. run with only python: so far all asv benchmarks are focusing python only 
changes, such as benchmark pure python eval types, pyarrow methods. This mode 
does not require spark.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to