xupefei opened a new pull request, #55981:
URL: https://github.com/apache/spark/pull/55981
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
DSv2 connectors that implement SupportsDelta currently must use a top-level
column for `rowId()`. If a connector returns a multi-segment field reference
(e.g. a nested struct field, or `_metadata.row_index` on a file-source-backed
table), analysis fails with a ClassCastException because Spark calls
`V2ExpressionUtils.resolveRefs[AttributeReference]`, while nested references
resolve to `Alias(GetStructField(...))`.
Widen `RewriteRowLevelCommand.resolveRowIdAttrs` and
`WriteDelta.rowIdAttrsResolved` to resolve as `NamedExpression` and flatten
back via `.toAttribute`. This supports both flat and nested row-id columns;
flat-column behavior is unchanged.
Why are the changes needed?
To unblocks Delta Lake DSv2 connectors that identify rows by file-source
metadata such as `(_metadata.file_path, _metadata.row_index)`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New tests are added to make sure it works for nested and flat cases.
### Was this patch authored or co-authored using generative AI tooling?
Yes, generated by Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
