ZiyaZa commented on code in PR #55586:
URL: https://github.com/apache/spark/pull/55586#discussion_r3266587125
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala:
##########
@@ -445,8 +445,8 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
invalidateCache) :: Nil
}
- case AppendData(r @ ExtractV2Table(v1: SupportsWrite), _, _,
- _, _, Some(write), analyzedQuery) if
v1.supports(TableCapability.V1_BATCH_WRITE) =>
+ case AppendWrite(r @ ExtractV2Table(v1: SupportsWrite), Some(write),
analyzedQuery)
Review Comment:
I'm unsure, but Claude suggested that a connector implementing both
`SupportsRowLevelOperations` and `V1_BATCH_WRITE` would have crashed without
this fallback. I don't know if it's a valid combination to be supported, but I
decided to keep this identical to what we would have had with AppendData before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
