longvu-db commented on PR #55456: URL: https://github.com/apache/spark/pull/55456#issuecomment-4499513771
## Auto-review results **1 critical issue found and fixed:** `CachingInMemoryTableCatalog.clearCache()` in `withCleanup` (line 82) was called as a companion-object static method, but no companion object exists — only an instance method. This would not compile. **Fix** (commit cb75a89): Get the server-side catalog instance and call `clearCache()` on it, matching the pattern used by the classic `DataSourceV2DataFrameSuite`: ```scala val serverSession = getServerSession(session) serverCatalog[CachingInMemoryTableCatalog](serverSession, "cachingcat").clearCache() ``` No other issues found. Test logic, assertions, cleanup patterns, imports, and style all look good. ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
