gengliangwang commented on PR #55973: URL: https://github.com/apache/spark/pull/55973#issuecomment-4511518829
Audited this PR for the same lessons surfaced by @viirya and @cloud-fan on #55938 (and applied to #55934 / #55939): 1. **Are the helpers redundant with an existing Scala API?** No — `resolveArrayIndex` and `checkArrayIndex` each wrap a specific `QueryExecutionErrors` throw (`invalidElementAtIndexError` / `invalidIndexOfZeroError` / `invalidArrayIndexError`) around the per-row bounds check. No existing object encapsulates these throws. 2. **Are the eval-path additions redundant?** No — master `GetArrayItem.nullSafeEval` was a multi-line bounds-check + throw body for ANSI mode. The new helper collapses it to one line. So no changes needed on this PR for that review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
