viirya commented on PR #56058:
URL: https://github.com/apache/spark/pull/56058#issuecomment-4520757934

   Thanks for the approval @cloud-fan! And good catch on the push-failure 
branch — same antipattern, same double-print, applied the same fix in 
`2c32cfd854a`. Pre-existing in `_do_cherry_pick` (the function was just 
factored out of the original `cherry_pick`, so the `clean_up(); fail(...)` 
lines pre-date this PR), but it's natural to tidy here while we're in the file.
   
   Final diff is now: new policy logic + 4 cleanups (3 from the previous 
follow-up + this one).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to