Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111426953
Not sure if it was too strict to level up `EqualsHashCode: Classes that
override equals should also override hashCode.` from warning to error.
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/ChunkFetchSuccess.java:65:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/RpcResponse.java:54:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/RpcRequest.java:63:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/ChunkFetchRequest.java:52:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/RpcFailure.java:54:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java:56:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
