pan3793 commented on code in PR #56092:
URL: https://github.com/apache/spark/pull/56092#discussion_r3295020608
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownTableSample.java:
##########
@@ -31,11 +32,14 @@ public interface SupportsPushDownTableSample extends
ScanBuilder {
/**
* Pushes down BERNOULLI (row-level) SAMPLE to the data source.
*/
- boolean pushTableSample(
+ @Deprecated(since = "4.2.0")
Review Comment:
in fact, this method should be treated as deprecated after SPARK-55978
(4.2.0), connectors do not need to implement this method if they already
implement the new pushTableSample method that has an additional `sampleMethod`
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
