dongjoon-hyun commented on code in PR #56082:
URL: https://github.com/apache/spark/pull/56082#discussion_r3295536409
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java:
##########
@@ -253,9 +249,7 @@ public void putShort(int rowId, short value) {
@Override
public void putShorts(int rowId, int count, short value) {
- for (int i = 0; i < count; ++i) {
- shortData[i + rowId] = value;
- }
+ java.util.Arrays.fill(shortData, rowId, rowId + count, value);
Review Comment:
ditto.
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java:
##########
@@ -395,9 +389,7 @@ public void putLong(int rowId, long value) {
@Override
public void putLongs(int rowId, int count, long value) {
- for (int i = 0; i < count; ++i) {
- longData[i + rowId] = value;
- }
+ java.util.Arrays.fill(longData, rowId, rowId + count, value);
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
