zhengruifeng commented on PR #56026:
URL: https://github.com/apache/spark/pull/56026#issuecomment-4531259678
Thanks for the re-review @cloud-fan! Addressed all 5 inline findings in
`fc2ee3d92`:
1. Stale `[PS]` example in `Component` docstring → swapped for `[DEPLOY]`
(still non-primary).
2. Dead commented-out `SPARKR` registry entry → removed.
3. Parser-unreachable with-space aliases → dropped (`SPARK CORE`, `PROJECT
INFRA`, `JAVA API`, `SPARK SHELL`, `WEB UI`, `FOLLOW UP`). Also flipped the
`Block Manager` canonical from `BLOCK MANAGER` to `BLOCK_MANAGER` so it's
parser-reachable. The corresponding underscore aliases remain so the
interactive prompt still accepts them.
4. Missing doctest for empty-body case → added `Title.parse("[SPARK-1234]")`
doctest covering the `__str__` no-text branch.
5. Stale `PRIMARY_COMPONENTS` reference in `prompt_for_components` docstring
→ reworded to "a primary Component (one with `primary=True`)".
Also corrected my earlier reply to @LuciferYang on the `[PROJECT INFRA]`
thread, which was wrong (the with-space form wasn't actually reachable from
`Title.parse` — only the underscore form is).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
