pan3793 commented on code in PR #56086:
URL: https://github.com/apache/spark/pull/56086#discussion_r3296129032
##########
core/src/test/scala/org/apache/spark/util/collection/SorterSuite.scala:
##########
@@ -17,13 +17,26 @@
package org.apache.spark.util.collection
+import java.lang.ref.WeakReference
import java.util.Arrays
+import java.util.concurrent.TimeUnit
import org.apache.spark.SparkFunSuite
import org.apache.spark.util.random.XORShiftRandom
class SorterSuite extends SparkFunSuite {
+ /** Run GC and wait until it has actually run, to free memory used by prior
tests. */
+ private def runGC(): Unit = {
Review Comment:
Okay, but could you lift and reuse `def runGC()` instead of replicating it
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
