HeartSaVioR commented on code in PR #56061:
URL: https://github.com/apache/spark/pull/56061#discussion_r3300552520
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityCheckerSuite.scala:
##########
@@ -307,174 +443,48 @@ class StateSchemaCompatibilityCheckerSuite extends
SharedSparkSession {
verifyException(keySchema, valueSchemaWithCollation, keySchema,
valueSchema,
ignoreValueSchema = false)
}
+}
- private def applyNewSchemaToNestedFieldInKey(newNestedSchema: StructType):
StructType = {
- applyNewSchemaToNestedField(keySchema, newNestedSchema, "key3")
- }
+class StateSchemaCompatibilityCheckerWithNullabilityWideningDisabledSuite
+ extends StateSchemaCompatibilityCheckerTestMixin {
- private def applyNewSchemaToNestedFieldInValue(newNestedSchema: StructType):
StructType = {
- applyNewSchemaToNestedField(valueSchema, newNestedSchema, "value3")
+ override protected def sparkConf: org.apache.spark.SparkConf = {
+ super.sparkConf.set(SQLConf.STATEFUL_OPERATOR_ALWAYS_NULLABLE_OUTPUT.key,
"false")
}
Review Comment:
Yeah good finding. StateSchemaCompatibilityChecker used the config during
development of this PR and we changed it while the test is left behind. Mostly
moving back to main suite (and reverting the refactor) seems valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
