uros-db commented on code in PR #56104: URL: https://github.com/apache/spark/pull/56104#discussion_r3303302828
########## common/unsafe/src/main/java/org/apache/spark/unsafe/types/BinaryView.java: ########## Review Comment: BinaryView is non-final with a protected ctor, but equals uses getClass() rather than instanceof. Either make the class final + ctor private (match UTF8String), or switch equals to instanceof. The two signals contradict each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
