cloud-fan commented on code in PR #55462:
URL: https://github.com/apache/spark/pull/55462#discussion_r3304069912
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DSv2TempViewWithStoredPlanTests.scala:
##########
@@ -33,21 +33,19 @@ import org.apache.spark.sql.types.{IntegerType, LongType,
StringType}
*/
trait DSv2TempViewWithStoredPlanTests extends DSv2ExternalMutationTestBase {
- private val T = "testcat.ns1.ns2.tbl"
- private val CT = "cachingcat.ns1.ns2.tbl"
- private val testIdent = Identifier.of(Array("ns1", "ns2"), "tbl")
+ // Uses testTable, cachingTestTable, and testIdent from
DSv2ExternalMutationTestBase.
Review Comment:
The hoist updated `$T` / `$CT` inside string interpolations but missed the
bare references — 25 call sites still use `session.table(T)` /
`session.table(CT)` on lines 45, 61, 79, 102, 121, 144, 170, 194, 220, 251,
279, 313, 344-346, 373-375, 404, 429, 454, 481, 513, 537, 563. The trait won't
compile. Fix:
- `session.table(T)` → `session.table(testTable)`
- `session.table(CT)` → `session.table(cachingTestTable)`
Worth running `build/sbt sql/Test/compile` locally — this commit hasn't been
built in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
