sarutak commented on PR #56108: URL: https://github.com/apache/spark/pull/56108#issuecomment-4546562012
> According to the PR title, we need to fix all occurrences, @sarutak . > > For example, the following is not handled by this PR currently. Could you double-check if we fix all? > > https://github.com/apache/spark/blob/5477eea9c01c6015c417940971e13b02381388b5/core/src/main/scala/org/apache/spark/api/r/RBackendAuthHandler.scala#L37 Thank you @dongjoon-hyun, I missed that part. I checked other occurrence using the following commands. ``` $ grep -rn --include="*.scala" 'secret\s*==\s*\w+[Ss]ecret\|clientSecret\|authSecret' $SPARK_HOME $ grep -rn --include="*.scala" 'secret\s*==\|==\s*secret\|!=\s*secret\|secret\s*!=' $SPARK_HOME $ grep -rn --include="*.scala" \ '(token|password|passphrase|credential|key)\s*==\s*\w|(==|!=)\s*(token|password|passphrase|credential)' \ $SPARK_HOME $ grep -rn --include="*.java" '(secret|token|password)\.equals(\|\.equals((secret|token|password)' \ $SPARK_HOME grep -rn --include="*.py" '(token|secret|auth_token)\s*==\s*|==\s*(token|secret|auth_token)' $SPARK_HOME ``` Then, I found one more problematic code in PySpark side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
