yadavay-amzn commented on PR #55466: URL: https://github.com/apache/spark/pull/55466#issuecomment-4552427697
@yaooqinn Thanks for the review! Addressed both points: 1. Applied the same fix to `StringUtils.splitSemiColonWithIndex` -- both files now handle the trailing block comment case. 2. Fixed line comment handling -- `hasPrecedingNonCommentString` now strips `--` line comments before checking for non-whitespace content. Added tests for your exact examples: - `"-- foo\n/* bar */"` → `[]` (comment-only, no spurious chunk) - `"SELECT 1; -- foo\n /* bar */"` → `["SELECT 1"]` (no trailing comment chunk) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
