gengliangwang commented on code in PR #56133:
URL: https://github.com/apache/spark/pull/56133#discussion_r3315381729


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3504,6 +3445,17 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val STREAMING_V2_PRUNE_COLUMNS_ENABLED =

Review Comment:
   why do we need a new conf here? will there be regressions?



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3504,6 +3445,17 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val STREAMING_V2_PRUNE_COLUMNS_ENABLED =
+    buildConf("spark.sql.streaming.v2.pruneColumns.enabled")
+      .internal()
+      .doc("When true, pruneColumns is called on V2 streaming scan builders 
that implement " +
+        "SupportsPushDownRequiredColumns. This communicates metadata columns 
to the scan " +
+        "builder so they appear in readSchema(). Disable if a connector's 
pruneColumns " +
+        "implementation is not compatible with being called in the streaming 
path.")
+      .withBindingPolicy(ConfigBindingPolicy.SESSION)

Review Comment:
   why do we need this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to