shrirangmhalgi commented on PR #56181: URL: https://github.com/apache/spark/pull/56181#issuecomment-4571784278
The test asserts `sameResult` only at the `BatchScanExec` level, but the full-plan assertion (`totalPlan1.sameResult(totalPlan2)`) is commented out pending #56182. Does this mean the DPP canonicalization fix alone isn't sufficient for Exchange reuse in practice - it also requires the JoinExec fix? If so, might be worth noting that dependency in the PR description so reviewers know the two PRs are coupled. Minor: `PruneFileSourcePartitionsSuite.scala` has a commented-out import (// import org.apache.spark.sql.classic.DataFrame) that looks like leftover debug code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
