fwc commented on PR #56190: URL: https://github.com/apache/spark/pull/56190#issuecomment-4578383847
Hi @cloud-fan, I changed the PR so that `SharedSparkSession` is now an empty alias of `classic.SparkSessionBinder` with a deprecation note that recommends using `sql.SparkSessionBinder` if possible. I am unsure with regards to the `SparkSessionBinder` name: AFAICS `SharedSparkSession` is/was _the_ testing trait (~500 extends/implements usages compared to ~150 usages of `QueryTest`, both according to Intellij's "Find Usages"). If it wouldn't be a breaking change, I'd want to rename `QueryTest` to `QueryTestHelpers` and `SparkSessionBinder` to `QueryTest`. What do you think? Maybe `QuerySuite`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
