gengliangwang opened a new pull request, #56228: URL: https://github.com/apache/spark/pull/56228
### What changes were proposed in this pull request? Add `ExpressionImplUtils.acosh(double x)` (the fdlibm `e_acosh.c` algorithm) and route `Acosh`'s eval and codegen paths through it. `Acosh.doGenCode` previously emitted a 12-line inline five-branch if/else; it now emits a single `ExpressionImplUtils.acosh(...)` call via `defineCodeGen`, and the eval path (the `UnaryMathExpression` function) calls the same helper instead of an inline lambda copy of the algorithm. `acosh` returns a primitive `double` (`NaN` for out-of-domain input), so the helper is a clean drop-in for both paths with no boxing and no null handling. This is a plain (non-ANSI, non-try/catch) type-independent block, in line with the broadened goal of SPARK-56908 to move fixed generated-Java logic into static Java helpers. ### Why are the changes needed? Part of SPARK-56908 (umbrella). Collapsing the duplicated 12-line algorithm to a single call shrinks the generated Java for every stage that uses `acosh`, and removes the eval/codegen duplication of the same fdlibm algorithm, helping with the JVM 64KB method / constant-pool limits, Janino compile time, and JIT work. ### Does this PR introduce _any_ user-facing change? No. The compiled behavior is identical; only the emitted Java source text changes. ### How was this patch tested? ``` build/sbt "catalyst/testOnly *MathExpressionsSuite" ``` 54/54 pass, including `acosh` and `SPARK-56089: asinh/acosh fdlibm algorithm coverage` (exercised both with and without whole-stage codegen). ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
