MaxGekk commented on code in PR #56198:
URL: https://github.com/apache/spark/pull/56198#discussion_r3330855271
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java:
##########
@@ -751,7 +762,10 @@ public final int appendStruct(boolean isNull) {
putNull(elementsAppended);
elementsAppended++;
for (WritableColumnVector c: childColumns) {
- if (c.type instanceof StructType || c.type instanceof VariantType) {
+ if (c.type instanceof StructType || c.type instanceof VariantType
+ || c.type instanceof CalendarIntervalType
Review Comment:
I've extracted the `CalendarIntervalType` fix into a separate PR, along with
a test that covers the struct-of-interval null-parent skew case:
apache/spark#56235 (SPARK-57184). This PR now only adds the nanosecond
timestamp types to the `appendStruct` recursion guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
