stevomitric commented on code in PR #56203:
URL: https://github.com/apache/spark/pull/56203#discussion_r3330975630
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala:
##########
@@ -885,6 +885,50 @@ class HashExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(HiveHash(Seq(time)), -1567775210)
}
+ test("HashExpression supports nanosecond timestamp types") {
+ // (epochMicros, nanosWithinMicro) pairs covering zero/mid/max nanos,
negative micros, and
+ // the Long epoch-micro boundaries.
+ val values = Seq(
+ TimestampNanosVal.fromParts(0L, 0.toShort),
+ TimestampNanosVal.fromParts(1L, 1.toShort),
+ TimestampNanosVal.fromParts(1234567890L, 999.toShort),
+ TimestampNanosVal.fromParts(-1L, 500.toShort),
+ TimestampNanosVal.fromParts(Long.MinValue, 0.toShort),
+ TimestampNanosVal.fromParts(Long.MaxValue, 999.toShort))
+
+ Seq(TimestampNTZNanosType(9), TimestampLTZNanosType(9),
+ TimestampNTZNanosType(7), TimestampLTZNanosType(7)).foreach { dt =>
+ (values.map(Literal.create(_, dt)) :+ Literal.create(null, dt)).foreach
{ lit =>
+ // checkEvaluation asserts the interpreted, codegen, and unsafe paths
all agree.
+ checkEvaluation(Murmur3Hash(Seq(lit), 42), Murmur3Hash(Seq(lit),
42).eval())
Review Comment:
Added a golden test. Expecteds are composed independently of the expression
under test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
