Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6763#discussion_r32338908
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala ---
@@ -45,7 +45,7 @@ class OpenHashSet[@specialized(Long, Int) T: ClassTag](
loadFactor: Double)
extends Serializable {
- require(initialCapacity <= (1 << 29), "Can't make capacity bigger than
2^29 elements")
+ require(initialCapacity <= (1 << 30), "Can't make capacity bigger than
2^30 elements")
--- End diff --
Ah right, because it chooses the next greater power of 2 as a capacity, so
this limit sounds correct.
Still I'm not sure why the code had 1 << 29 then, and actually the old
`POSITION_MAX` was `0x0EFFFFFF` not `0xEFFFFFFF`. It looks like it really
should be `0x7FFFFFFF` but maybe we should check with @rxin to make sure I'm
not missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
