mridulm commented on code in PR #55347:
URL: https://github.com/apache/spark/pull/55347#discussion_r3337724812
##########
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala:
##########
@@ -69,4 +69,7 @@ private[spark] class MetadataFetchFailedException(
shuffleId: Int,
reduceId: Int,
message: String)
- extends FetchFailedException(null, shuffleId, -1L, -1, reduceId, message)
+ extends FetchFailedException(null, shuffleId, -1L, -1, reduceId, message) {
+ override def toTaskFailedReason: TaskFailedReason = MetadataFetchFailed(
+ shuffleId, reduceId, Utils.exceptionString(this))
+}
Review Comment:
This is in principle violation the intent of
[this](https://github.com/apache/spark/blob/224231815105f6c0f333e866ef50c48810720f37/core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala#L59)
- by bypassing propagating fetch failure.
Will need to see if this cause any other side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
