gaogaotiantian commented on code in PR #56259: URL: https://github.com/apache/spark/pull/56259#discussion_r3337973484
########## python/pyspark/pipelines/tests/test_auto_cdc_flow.py: ########## @@ -0,0 +1,183 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import unittest +from typing import cast + +from pyspark.errors import PySparkTypeError +from pyspark.sql import Column +from pyspark.testing.connectutils import ( + should_test_connect, + connect_requirement_message, +) + +if should_test_connect: + from pyspark import pipelines as dp + from pyspark.pipelines.graph_element_registry import graph_element_registration_context + from pyspark.pipelines.flow import AutoCdcFlow + from pyspark.pipelines.tests.local_graph_element_registry import LocalGraphElementRegistry Review Comment: The reason I put those under check is - I think pipelines in OSS only works on connect. It's possible that in the future we are more explicit about it (by importing connect related stuff in these modules). I think it's clearer that we put these under the check to indicate that they rely on connect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
