cloud-fan commented on code in PR #56263:
URL: https://github.com/apache/spark/pull/56263#discussion_r3339188138
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -402,9 +402,12 @@ abstract class JdbcDialect extends Serializable with
Logging {
private[jdbc] class JDBCSQLBuilder extends V2ExpressionSQLBuilder {
// SPARK-53454: Produce portable SQL for AlwaysTrue/AlwaysFalse predicates.
// Some databases (Oracle, DB2) do not support bare TRUE/FALSE in WHERE
clauses.
+ // The result is parenthesized so it stays valid when nested as an operand
of a
+ // larger expression (e.g. `(`a` = 3) = (1 = 1)` or `(1 = 1) IS NOT
NULL`), not
Review Comment:
Good catch, removed the stray backticks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
