MaxGekk commented on code in PR #56199:
URL: https://github.com/apache/spark/pull/56199#discussion_r3339964656
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1689,23 +1689,27 @@ object CodeGenerator extends Logging {
val jt = javaType(dataType)
dataType match {
case udt: UserDefinedType[_] => getValue(input, udt.sqlType, ordinal)
- case _ if isPrimitiveType(jt) =>
s"$input.get${primitiveTypeName(jt)}($ordinal)"
- case _ => PhysicalDataType(dataType) match {
- case _: PhysicalArrayType => s"$input.getArray($ordinal)"
- case PhysicalBinaryType => s"$input.getBinary($ordinal)"
- case _: PhysicalGeographyType => s"$input.getGeography($ordinal)"
- case _: PhysicalGeometryType => s"$input.getGeometry($ordinal)"
- case PhysicalCalendarIntervalType => s"$input.getInterval($ordinal)"
- case PhysicalTimestampNTZNanosType =>
s"$input.getTimestampNTZNanos($ordinal)"
- case PhysicalTimestampLTZNanosType =>
s"$input.getTimestampLTZNanos($ordinal)"
- case t: PhysicalDecimalType => s"$input.getDecimal($ordinal,
${t.precision}, ${t.scale})"
- case _: PhysicalMapType => s"$input.getMap($ordinal)"
- case PhysicalNullType => "null"
- case _: PhysicalStringType => s"$input.getUTF8String($ordinal)"
- case t: PhysicalStructType => s"$input.getStruct($ordinal,
${t.fields.length})"
- case PhysicalVariantType => s"$input.getVariant($ordinal)"
- case _ => s"($jt)$input.get($ordinal, null)"
- }
+ case _ =>
+ TypeOps(dataType).map(_.getCodegenGetter(input, ordinal)).getOrElse {
Review Comment:
@davidm-db @stevomitric @dejankrak-db Could you review new PR
https://github.com/apache/spark/pull/56266 which only registers
TimestampNTZNanosType / TimestampLTZNanosType by overriding existing
TypeOps/TypeApiOps methods, with no new framework methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
