dejankrak-db commented on code in PR #56237:
URL: https://github.com/apache/spark/pull/56237#discussion_r3340607491
##########
sql/core/src/test/resources/sql-tests/inputs/extract-value-resolution-edge-cases.sql:
##########
@@ -8,3 +8,13 @@ SELECT col1.a, a FROM t1 ORDER BY col1.a;
SELECT split(col1, '-')[1] AS a FROM VALUES('a-b') ORDER BY split(col1,
'-')[1];
DROP TABLE t1;
+
+-- SPARK-57186: extracting a field/element/key from a NullType base returns
NULL instead of
+-- throwing INVALID_EXTRACT_BASE_FIELD_TYPE (SQL NULL propagation; a NullType
column can arise e.g.
+-- from schema evolution with missing columns). This applies uniformly to
dotted field access
+-- (`col.a`) and the subscript forms (`col[0]`, `col['key']`), and is
implemented at the
+-- user-facing resolution sites (ExtractValue.applyOrNull) without changing
the shared
+-- ExtractValue.extractValue utility.
+SELECT col.a FROM (SELECT null AS col) t;
+SELECT col[0] FROM (SELECT null AS col) t;
Review Comment:
Addressed the column-name nit: `col[0]`/`col['key']` on a `NullType` base
are now aliased via `toPrettySQL` (so they're named `col[0]`/`col['key']`
instead of NULL, matching the non-null subscript naming); `CleanupAliases`
trims this where it isn't a top-level projection output. Also updated the PR
description to reflect the current implementation. Thanks for the careful
reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
