gaogaotiantian commented on PR #56051: URL: https://github.com/apache/spark/pull/56051#issuecomment-4607515592
Hi @shrirangmhalgi , like I mentioned in the previous message - this does not quite make sense. You are not removing any dead code, you move a "dead" code from one place to another - it's still dead. It's supposed to be dead because it's an assertion. It should never happen. It is better in the `else` case because it's clear why the assertion would fail. Thank you for your contribution but I don't think this PR should be merged. I'll close it for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
