cloud-fan commented on code in PR #56282:
URL: https://github.com/apache/spark/pull/56282#discussion_r3345670273
##########
dev/merge_spark_pr.py:
##########
@@ -1098,11 +1105,64 @@ def initialize_jira():
timeout=(JIRA_CONNECT_TIMEOUT, 30),
)
else:
- print("Neither JIRA_ACCESS_TOKEN nor JIRA_USERNAME/JIRA_PASSWORD are
set.")
- continue_maybe("Continue without jira?")
+ fail(
+ "Neither JIRA_ACCESS_TOKEN nor JIRA_USERNAME/JIRA_PASSWORD are
set. Configure JIRA "
Review Comment:
This PR is to add more hardening, dropping JIRA_USERNAME/JIRA_PASSWORD looks
reasonable but let's do it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
