pchintar commented on PR #56240: URL: https://github.com/apache/spark/pull/56240#issuecomment-4610564860
@cloud-fan & @shrirangmhalgi thnx for the review! I made some changes as per your feedback: * I Updated the Scala `@since` annotations and the PySpark `versionchanged` annotation from `4.2.0` to `4.3.0`. * I added a PySpark doctest example demonstrating the new 4-argument form of `regexp_replace` with the `position` parameter, and so the documentation now covers both the existing 3-argument usage and the new 4-argument usage. * I kept the Scala parameter name as `pos` instead of `position` because `functions.scala` already defines overloaded public methods named `position(...)`; using `position` as the parameter name in this overload causes ambiguous resolution against those existing methods inside the same object. So, I updated the Scaladoc wording to explicitly reference `pos`, so the documentation now matches the signature clearly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
