gengliangwang commented on PR #56276: URL: https://github.com/apache/spark/pull/56276#issuecomment-4615089890
Flagging against the scope guidance added to the umbrella [SPARK-56908](https://issues.apache.org/jira/browse/SPARK-56908). This is a source-only dead-branch elimination: Janino constant-folds `if (true)`/`if (false)`, so there is no bytecode change. Measured on TPC-DS whole-stage codegen, even the most frequent such patterns (×358–445, ~0.4% of generated source) saved compile time below the run-to-run noise floor (~0.7%). The changes that *were* worth it removed more than source — e.g. SPARK-57198 dropped an unreachable `references[]`/constant-pool entry, which Janino cannot recover. Before merging, please confirm this removes more than source text (a `references[]`/constant-pool entry, or keeps a method under the 64KB limit) — raw occurrence count alone is not sufficient. If not, it adds codegen-logic complexity for negligible benefit and should be dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
