HyukjinKwon commented on code in PR #56312:
URL: https://github.com/apache/spark/pull/56312#discussion_r3352484938
##########
dev/sparktestsupport/modules.py:
##########
@@ -1680,6 +1680,40 @@ def __hash__(self):
test_tags=["org.apache.spark.tags.DockerTest"],
)
+
+# dev_tools is a pseudo module that contains all the dev related files that
+# won't impact the CI build and tests (except for CI which is forced to
+# run anyway).
+# This module is created so modifying files in this module won't trigger any
+# tests to run.
+dev_tools = Module(
+ name="dev-tools",
+ dependencies=[],
+ source_file_regexes=[
+ ".*README.md",
+ ".*AGENTS.md",
+ r".*\.gitignore",
+ "CONTRIBUTING.md",
+ ".asf.yaml",
+ "SECURITY.md",
+ "NOTICE-binary",
+ "LICENSE-binary",
+ "ui-test/package.json",
+ "ui-test/package-lock.json",
+ "scalastyle-config.xml",
+ "dev/checkstyle.xml",
+ "dev/checkstyle-suppressions.xml",
+ "dev/spark-test-image/lint/Dockerfile",
+ "dev/lint-python",
+ "dev/lint-scala",
+ "dev/reformat-python",
+ "dev/structured_logging_style.py",
+ "dev/merge_spark_pr.py",
Review Comment:
We actually have unittests in this script. Shouldn't we run it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
