dongjoon-hyun commented on code in PR #56293:
URL: https://github.com/apache/spark/pull/56293#discussion_r3358960662
##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -96,6 +97,8 @@ public class TaskMemoryManager {
private final MemoryManager memoryManager;
+ private final MemoryAllocator tungstenMemoryAllocator;
Review Comment:
~I checked the usage of `tungstenMemoryAllocator` variable in this PR. For
me, it's not required. Let's revert this change.~
##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -96,6 +97,8 @@ public class TaskMemoryManager {
private final MemoryManager memoryManager;
+ private final MemoryAllocator tungstenMemoryAllocator;
Review Comment:
~At the first glance, I'm wondering if this is an inevitable change. If this
is not inevitable, I'd prefer to avoid the change of constructor by keeping the
existing indirect path, `memoryManager.tungstenMemoryAllocator()`~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
