sunchao commented on PR #56227: URL: https://github.com/apache/spark/pull/56227#issuecomment-4628017637
Thanks for the review! > The `Slice` foldability guard is inconsistent between the two files ... Updated the PR to add matching `start.foldable && length.foldable` guard to the `Slice` case in `ProjectionOverSchema` to keep it aligned with `SelectedField` and the adjacent `ElementAt` handling. > `ProjectionOverLambdaVariable.project` still uses `semanticEquals` ... The current head already matches lambda variables by `exprId` in `ProjectionOverLambdaVariable.project`, so no additional change is needed there. > `projectArrayHigherOrderFunction` now relies .. I left the reference-identity check as-is since it directly follows from `projectedArguments`: only the retyped element variables are copied, while the remaining arguments retain their original instances. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
