cloud-fan commented on code in PR #56325:
URL: https://github.com/apache/spark/pull/56325#discussion_r3363855442
##########
udf/worker/grpc/pom.xml:
##########
@@ -24,7 +24,7 @@
<parent>
<groupId>org.apache.spark</groupId>
<artifactId>spark-parent_2.13</artifactId>
- <version>5.0.0-SNAPSHOT</version>
+ <version>4.2.0-SNAPSHOT</version>
Review Comment:
The parent version has to match the root `pom.xml`, and `branch-4.x` is
currently on `4.2.0-SNAPSHOT` (not 4.3.0 yet), so `4.2.0-SNAPSHOT` is the
correct value here. This was the actual bug — the module had `5.0.0-SNAPSHOT`
(master's version) leaking onto the branch.
That said, you have a point that the branch version looks stale — we should
likely bump `branch-4.x` to `4.3.0-SNAPSHOT` in a separate change. But that's a
branch-wide version bump (root POM + all modules), so it's out of scope for
this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
