yadavay-amzn commented on code in PR #56243:
URL: https://github.com/apache/spark/pull/56243#discussion_r3364250132
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CoalesceShufflePartitions.scala:
##########
@@ -171,7 +200,8 @@ case class CoalesceShufflePartitions(session: SparkSession)
extends AQEShuffleRe
if (shuffleStages.forall(s => isSupported(s.shuffleStage.shuffle))) {
// The recursion stops here, we need to call
`p.exists(isExplodingJoin)` and find out if
// there is any exploding join in this sub-plan-tree.
- Seq(CoalesceGroup(shuffleStages, hasExplodingJoin ||
p.exists(isExplodingJoin)))
+ Seq(CoalesceGroup(shuffleStages, hasExplodingJoin ||
p.exists(isExplodingJoin),
Review Comment:
Added comment: `isPartitionedJoin(p)` catches the case where `p` itself is
the join node; `p.exists(...)` catches cases where the join is below
intermediate nodes like Project or Filter (e.g., `Project(SortMergeJoin(...))`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
