szehon-ho commented on PR #56352: URL: https://github.com/apache/spark/pull/56352#issuecomment-4636312707
cc @cloud-fan, would appreciate a look. For context on why these tests are moving around: the most recent additions in #56242 were placed correctly given the structure that existed at the time -- there's nothing wrong with where they were put. The real issue is that the original split I introduced in #54391 wasn't a great organization: the traits were divided by top-level vs. nested columns and by mixed concerns, which made it ambiguous where a given scenario's tests should live. This PR reorganizes the traits by *scenario* (extra source column, extra target column, type widening, mixed) so each test has an obvious home, regardless of whether it's a top-level or nested case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
