kiyeonjeon21 commented on PR #54058: URL: https://github.com/apache/spark/pull/54058#issuecomment-4643306818
Thanks for updating it. I think I wasn’t clear enough earlier. The new test passes `Some(null)` directly to the helper, but I think that would throw both before and after this change. I meant the instance path: `KafkaMicroBatchStream.metrics()` used to create `Some(latestPartitionOffsets)` while `latestPartitionOffsets` was still null. Would it be possible to test the instance `metrics()` call before `latestOffset()` initializes it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
