andreaschat-db commented on code in PR #56121:
URL: https://github.com/apache/spark/pull/56121#discussion_r3372635544
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/transactions/Transaction.java:
##########
@@ -66,6 +67,20 @@ public interface Transaction extends Closeable {
*/
void abort();
+ /**
+ * Attempts to register materialized scans against this transaction's read
set.
+ * <p>
+ * An example use case is cache reuse. Spark passes the scans of a candidate
cached subtree
+ * for the transaction's catalog and the connector decides whether to accept
them.
+ * <p>
+ * The connector must either accept (returning {@code true} after adding any
relevant scans
+ * to the read set) or refuse (returning {@code false} without modifying the
read set).
+ *
+ * @param scans the scans to register.
Review Comment:
Clarified both 1 and 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
