MaxGekk opened a new pull request, #56372:
URL: https://github.com/apache/spark/pull/56372
### What changes were proposed in this pull request?
Add `TimestampLTZNanosType` and `TimestampNTZNanosType` (at min and max
precision) to the shared type sets in `DataTypeTestUtils` (`ordered`,
`atomicTypes`, and the derived `propertyCheckSupported` and
`atomicArrayTypes`), mirroring the existing `timeTypes` pattern. Also refresh a
stale comment in `OrderingSuite` now that the generic `atomicTypes` loop covers
the nanosecond timestamp types.
### Why are the changes needed?
`TimestampLTZNanosType` and `TimestampNTZNanosType` extend `DatetimeType` ->
`AtomicType` but were absent from the `DataTypeTestUtils` type sets. Adding
them triggers broader generic test coverage across `OrderingSuite`,
`PredicateSuite`, `ConditionalExpressionSuite`, `ArithmeticExpressionSuite`
(LEAST/GREATEST), `SortSuite`, `RandomDataGeneratorSuite`, and the Cast suites,
exposing any gaps in the nanosecond timestamp type infrastructure.
**This PR depends on SPARK-57317 (#56371)**, which fixes `Literal.create`
for external nanosecond timestamp values; without it the new coverage in
`PredicateSuite` ("IN with different types") fails. CI here is expected to be
red until #56371 is merged and this branch is rebased.
### Does this PR introduce _any_ user-facing change?
No. Test-only change.
### How was this patch tested?
Ran the affected suites with this change on top of SPARK-57317:
`OrderingSuite`, `RandomDataGeneratorSuite`, `PredicateSuite`,
`ConditionalExpressionSuite`, `ArithmeticExpressionSuite`, `CastSuiteBase`,
`CastWithAnsiOnSuite`, `CastWithAnsiOffSuite`, `SortSuite`, `UnsafeRowSuite`.
All passed.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
