dbtsai commented on PR #56377: URL: https://github.com/apache/spark/pull/56377#issuecomment-4654627218
Added the concurrent coverage that was the remaining (optional) gap (commit `2211e16688c`). cc @viirya @cloud-fan The foreachBatch cleaner race previously had tests only for the already-closing and `cleanUpAll()` paths. Added a deterministic-interleaving test mirroring the `SparkConnectStreamingQueryCache` 200-iteration latch test: it registers a runner concurrently with the shutdown sequence (`close()` then `cleanUpAll()`) and asserts, across every interleaving, that the runner is closed and no listener is left registered on `session.streams`. Note the two invariants have different backing guarantees: the runner cleanup is protected by `ConcurrentHashMap` per-key linearizability (same as the query path), while the listener removal leans on the `listenerRegistered` volatile plus session GC as the backstop -- this test exercises that path directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
