gaogaotiantian commented on code in PR #56380:
URL: https://github.com/apache/spark/pull/56380#discussion_r3377180795
##########
python/pyspark/sql/pandas/conversion.py:
##########
@@ -113,7 +113,16 @@ def create_arrow_array_from_pandas(
else:
mask = series.isnull()
try:
- return pa.Array.from_pandas(series, mask=mask, type=arrow_type,
safe=safecheck)
Review Comment:
I think it's better to have an explicit arrow version check here, instead of
an implicit "noop". The reason is that we can confidently remove the whole
branch when we drop support for pyarrow < 19.0.0, instead of parsing the
comments and try to understand how to refactor the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
