MaxGekk commented on PR #56392: URL: https://github.com/apache/spark/pull/56392#issuecomment-4658651959
@uros-b Thanks for the review! Added a test for the null `TIME` value path (it renders as JSON `null`) in commit 6c8fdae81c6. I also pushed a small follow-up: the nanosecond timestamp ops now override `formatExternal` to raise `UNSUPPORTED_FEATURE.TIMESTAMP_NANOS_TO_STRING` directly, instead of relying on `Row.toJson` falling back to the internal-value `format`. That let `Row.toJson` drop the now-redundant `format` fallback and route purely through `formatExternal`. The PR description is updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
