MaxGekk commented on PR #56355: URL: https://github.com/apache/spark/pull/56355#issuecomment-4667865986
@cloud-fan re the blocking item (`Row(...).json` ClassCastException + over-broad user-facing scope) — resolved: - The `Row.json` CCE was the pre-existing framework-wide `Row.jsonValue` → `ops.format` issue (`TimeType` hit it too), so I split the structural fix into #56392 / SPARK-57338 (now merged), which routes `Row.jsonValue` through `formatExternal`. This PR is rebased on top, and the nanos ops now render the external value through `formatExternal` (NTZ zone-independent, LTZ in the session zone, at the column precision), so `Row.json` on a nanos column renders instead of throwing — covered by a new `RowJsonSuite` test. - I've tightened the "user-facing change" section per your and @uros-b's notes: `EXPLAIN` and SQL-literal `toSQLValue` are unchanged (they don't route through the framework); the actual deltas are the CAST path (`format` no longer throws; rendered output unchanged) and `Row.json` on nanos columns now rendering. Thanks for independently verifying the three callers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
