stevomitric opened a new pull request, #56431:
URL: https://github.com/apache/spark/pull/56431
### What changes were proposed in this pull request?
This PR deletes that validator and moves the requirement into the getter:
`SQLConf.timestampNanosTypesEnabled` now returns true only when
`spark.sql.types.framework.enabled` is also true.
### Why are the changes needed?
Enabling the flag the normal way crashes Spark:
```scala
val spark = SparkSession.builder()
.master("local[1]")
.config("spark.sql.timestampNanosTypes.enabled", "true")
.getOrCreate() // fine — options are applied lazily
spark.sql("SELECT 1") // java.lang.StackOverflowError
```
The validator runs while the session conf is being built (during
`mergeSparkConf`), and `SQLConf.get` asks for that same conf which starts
building it again, forever.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Tests in this PR.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Fable 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
