iemejia commented on PR #55923: URL: https://github.com/apache/spark/pull/55923#issuecomment-4673081419
Thanks for catching this! You were right -- the implementation was indeed missing. It turns out the factory changes were accidentally dropped during a rebase that conflicted with SPARK-56804 (which landed the `DateToTimestampNTZUpdater` bulk read). The conflict resolution discarded all the factory hunks, not just the conflicting one. I was able to recover the original implementation from the reflog and re-applied it (excluding `DateToTimestampNTZUpdater` which SPARK-56804 already handles). The four remaining updaters now have bulk read paths with 2.0x-2.6x speedups. Updated title and description accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
