GitHub user davies opened a pull request:

    https://github.com/apache/spark/pull/6792

    [SPARK-7186] [SQL] Decouple internal Row from external Row

    Currently, we use o.a.s.sql.Row both internally and externally. The 
external interface is wider than what the internal needs because it is designed 
to facilitate end-user programming. This design has proven to be very error 
prone and cumbersome for internal Row implementations.
    
    As a first step, we create an InternalRow interface in the catalyst module, 
which is identical to the current Row interface. And we switch all internal 
operators/expressions to use this InternalRow instead. When we need to expose 
Row, we convert the InternalRow implementation into Row for users.
    
    For all public API, we use Row (for example, data source APIs), which will 
be converted into/from InternalRow by CatalystTypeConverters.
    
    For all internal data sources (Json, Parquet, JDBC, Hive), we use 
InternalRow for better performance, casted into Row in buildScan() (without 
change the public API). When create a PhysicalRDD, we cast them back to 
InternalRow.
    
    cc @rxin @marmbrus @JoshRosen 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davies/spark internal_row

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6792
    
----
commit 7cbced8884559f6f62d292d8b5cdba463fa017ad
Author: Davies Liu <[email protected]>
Date:   2015-06-12T21:44:32Z

    separate Row and InternalRow

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to