Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6707#discussion_r32358886
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala
---
@@ -251,9 +377,20 @@ class ReceivedBlockHandlerSuite
(blockIds, storeResults)
}
+ /** Store block using a handler */
+ private def storeBlock(
--- End diff --
Instead of adding this, please use the other `storeBlocks`. there is
already semantics here that randomized blockIds etc to prevent any conflicts
due to the same block id being used. So best to use this rather than use the
same block id every time and mask errors.
Also use the returned block Id to clean up the block later, in
`testRecordCount`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
